This repository was archived by the owner on Sep 13, 2023. It is now read-only.
Open
Conversation
Owner
|
Thanks! Yeah, failure-derive requires and explicit I think we can use the failure macros, though, if we also re-export the functions they use. And speaking of failure macros, CI fails with
because we use one of those in the thumbnails guide! :) We could alternatively use |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on what I found in studio-lucia/sss_fontbuild#2, it looks like it's not possible to use the
failure/failure_derivereexports from the prelude; it seems to be necessary to independently import those crates anyway. As a result, there doesn't seem to really be a reason to reexport them.I also removed the
failure_deriveimport in this module, since it's not used internally either.